Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSSDK: remove wasm dependencies & optimized the bundling size #1417

Merged
merged 9 commits into from
Oct 20, 2023
Merged

JSSDK: remove wasm dependencies & optimized the bundling size #1417

merged 9 commits into from
Oct 20, 2023

Conversation

Leechael
Copy link
Contributor

No description provided.

kvinwang
kvinwang approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@kvinwang kvinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leechael Leechael force-pushed the jssdk-zero-wasm-dependencies branch from 53bd7c5 to b0b8658 Compare October 19, 2023 13:15
@Leechael Leechael changed the title JSSDK: remove wasm dependencies JSSDK: remove wasm dependencies & optimized the bundling size Oct 20, 2023
@Leechael
Copy link
Contributor Author

Before:

npm notice 
npm notice 📦  @phala/[email protected]
npm notice === Tarball Contents === 
npm notice 11.4kB  LICENSE                 
npm notice 10.2kB  README.md               
npm notice 345.7kB dist/browser/index.d.mts
npm notice 345.7kB dist/browser/index.d.ts 
npm notice 2.0MB   dist/browser/index.js   
npm notice 2.0MB   dist/browser/index.mjs  
npm notice 345.7kB dist/node/index.d.mts   
npm notice 345.7kB dist/node/index.d.ts    
npm notice 1.4MB   dist/node/index.js      
npm notice 1.4MB   dist/node/index.mjs     
npm notice 2.9kB   package.json            
npm notice === Tarball Details === 
npm notice name:          @phala/sdk                              
npm notice version:       0.5.3-nightly-20231013                  
npm notice filename:      @phala/sdk-0.5.3-nightly-20231013.tgz   
npm notice package size:  1.6 MB                                  
npm notice unpacked size: 8.2 MB                                  
npm notice shasum:        6db7b78ef54c20036a486d60ebe645346453269c
npm notice integrity:     sha512-5LooEp7I2IDXd[...]bTlPWS+qhUxLw==
npm notice total files:   11                                      
npm notice 
phala-sdk-0.5.3-nightly-20231013.tgz

After:

npm notice 
npm notice 📦  @phala/[email protected]
npm notice === Tarball Contents === 
npm notice 11.4kB  LICENSE                 
npm notice 10.2kB  README.md               
npm notice 170.9kB dist/browser/index.d.mts
npm notice 170.9kB dist/browser/index.d.ts 
npm notice 686.8kB dist/browser/index.js   
npm notice 684.6kB dist/browser/index.mjs  
npm notice 170.9kB dist/node/index.d.mts   
npm notice 170.9kB dist/node/index.d.ts    
npm notice 335.5kB dist/node/index.js      
npm notice 332.1kB dist/node/index.mjs     
npm notice 3.3kB   package.json            
npm notice === Tarball Details === 
npm notice name:          @phala/sdk                              
npm notice version:       0.5.4-nightly-20231020                  
npm notice filename:      @phala/sdk-0.5.4-nightly-20231020.tgz   
npm notice package size:  363.8 kB                                
npm notice unpacked size: 2.7 MB                                  
npm notice shasum:        20a65587257119982c6e0c0080d5e83ccb04c0fb
npm notice integrity:     sha512-RO2uG2CMjloSd[...]0kmU+bCYbPKDQ==
npm notice total files:   11                                      
npm notice 
phala-sdk-0.5.4-nightly-20231020.tgz

@Leechael Leechael merged commit e5beb1d into master Oct 20, 2023
9 checks passed
@Leechael Leechael deleted the jssdk-zero-wasm-dependencies branch October 20, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvinwang kvinwang kvinwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leechael @kvinwang